Skip to content

Update unicode to v5.0.1#1031

Merged
thomashoneyman merged 3 commits into
purescript:masterfrom
deviant-forks:update-unicode-to-v5.0.1
Nov 17, 2021
Merged

Update unicode to v5.0.1#1031
thomashoneyman merged 3 commits into
purescript:masterfrom
deviant-forks:update-unicode-to-v5.0.1

Conversation

@maxdeviant

Copy link
Copy Markdown
Contributor

This PR updates unicode to v5.0.1.

purescript-contrib/purescript-unicode@v5.0.0...v5.0.1

Comment thread src/groups/purescript-contrib.dhall Outdated
, "maybe"
, "partial"
, "prelude"
, "quickcheck"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were quite a few dependencies added between v5.0.0 and v5.0.1.

Not sure which ones we should be including here (e.g., do we include quickcheck even if it's just a test dependency?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to include dependencies in the source code, so nothing that's only a test dependency. I'm assuming that the new dependencies are added just because they were previously transitive?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, purescript-contrib/purescript-unicode#35 looks like it was dealing with transitive deps. But we don't need any test-only dependencies included in the package sets.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, reverted the changes to the dependency list 👍🏻

I can't wait for Spago targets 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants