Skip to content

Add foreign implementation for push#240

Merged
thomashoneyman merged 5 commits into
purescript:masterfrom
i-am-the-slime:patch-1
Jun 16, 2023
Merged

Add foreign implementation for push#240
thomashoneyman merged 5 commits into
purescript:masterfrom
i-am-the-slime:patch-1

Conversation

@i-am-the-slime

@i-am-the-slime i-am-the-slime commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Avoid array allocation for push

The previous implementation would create a new array every time
This one is a pretty faithful call into JS's push.

Supersedes #237 and closes #236

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Comment thread src/Data/Array/ST.js Outdated
i-am-the-slime and others added 2 commits June 16, 2023 21:23
Co-authored-by: Thomas Honeyman <hello@thomashoneyman.com>
@thomashoneyman thomashoneyman merged commit 7286121 into purescript:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement STArray.push via proper FFI

2 participants