Skip to content

Add tests and fix enumFromTo, closes #15#16

Merged
garyb merged 1 commit into
purescript:masterfrom
sharkdp:master
May 31, 2016
Merged

Add tests and fix enumFromTo, closes #15#16
garyb merged 1 commit into
purescript:masterfrom
sharkdp:master

Conversation

@sharkdp

@sharkdp sharkdp commented Apr 3, 2016

Copy link
Copy Markdown
Contributor

I'm not sure if the changes to .travis.yml and package.json are fine...

@sharkdp

sharkdp commented Apr 3, 2016

Copy link
Copy Markdown
Contributor Author

This PR actually depends on purescript/purescript#1963 as I'm using Eq and Ord deriving. This is why the build fails.

@garyb

garyb commented Apr 3, 2016

Copy link
Copy Markdown
Member

Looks great, and thanks for adding the tests. I'll leave this open until we figure out what we're doing with getting the deriving changes included.

@garyb

garyb commented May 30, 2016

Copy link
Copy Markdown
Member

Could you rebase this please?

@sharkdp

sharkdp commented May 31, 2016

Copy link
Copy Markdown
Contributor Author

Rebased, but cannot get this working (neither on Travis, nor locally)... I need psc 0.9.0 in order to parse the Foldable.js FFI code, but pulp 8.2.1 does not work with psc 0.9.0...

@paf31

paf31 commented May 31, 2016

Copy link
Copy Markdown
Contributor

You have to either build Pulp 9 with psc 0.8.*, or use vanilla psc to build this, I think.

@garyb

garyb commented May 31, 2016

Copy link
Copy Markdown
Member

No problem, I'll cherry-pick this and fix up anything else that is required. Thanks!

@sharkdp

sharkdp commented May 31, 2016

Copy link
Copy Markdown
Contributor Author

You have to either build Pulp 9 with psc 0.8.*, or use vanilla psc to build this, I think.

Thanks for the hint. The tests pass locally if I build everything manually with psc 0.9.0. I cannot get Pulp master working (with both psc 0.9 and 0.8)... what is the right procedure to install Pulp manually? I tried following the steps in .travis.yml ...

@garyb

garyb commented May 31, 2016

Copy link
Copy Markdown
Member

I had difficulty getting pulp to build from master too, I can't remember what I did to make it work in the end. I think there were dependency issues, perhaps a missing commit hash or something. @hdgarrood?

@hdgarrood

Copy link
Copy Markdown
Contributor

Yeah, that sounds plausible. I think pulp should be updated to point at psvm master now, the PR it needed has been merged now IIRC. I can't get to a computer to address this until this weekend unfortunately.

@garyb

garyb commented May 31, 2016

Copy link
Copy Markdown
Member

No need for me to do anything, checked out locally this builds and tests successfully. Thank you!

@garyb garyb merged commit db0b3d6 into purescript:master May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants