Set background-color on search input#1409
Draft
pete-murphy wants to merge 2 commits into
Draft
Conversation
pete-murphy
commented
Jul 13, 2026
| pursuitColor = rgb 0x1d 0x22 0x2d | ||
| rds = px 3.0 | ||
|
|
||
| backgroundColor white |
Author
There was a problem hiding this comment.
I didn't check until after making this change, but Pursuit has different dark mode styles for its search input:
.top-banner__form input {
border: 1px solid #1d222d;
border-radius: 3px;
background-color: #ffffff;
color: #1d222d;
font-weight: 300;
line-height: 2;
padding: 0.21em 0.512em;
width: 100%;
}
@media (prefers-color-scheme: dark) {
.top-banner__form input {
border-color: #1d222d;
background-color: #141417;
color: #dedede;
}
}
Maybe we should match that? Would mean moving the style declaration to Nevermind, should be even simpler than that, we should be able to just re-use the same styles from Pursuit CSS (and delete a lot of inline styles here) by using the same classes as Pursuit.insertStyle in App.purs so we can use the media query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1408
Description of the change
Explicitly setting
background-color: whitein the search<input>'s styles, to override UA stylesheet default ofbackground-color: Fieldwhich has poor contrast with the input'scolor: hsl(221.25, 21.62%, 14.51%)in dark mode.Before
After
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊