FRAM-929 fix content type for heic image renders#62
Merged
Conversation
bantonj
previously approved these changes
Apr 21, 2026
bantonj
reviewed
Apr 21, 2026
| return base64.StdEncoding.EncodeToString(hash.Sum(nil)) | ||
| } | ||
|
|
||
| func contentTypeFromData(data []byte) string { |
Collaborator
There was a problem hiding this comment.
I think it's probably better to pass the image type into beforeResponse than try to figure it out here.
Collaborator
Author
There was a problem hiding this comment.
Ok I will see about updating it.
@bantonj also is there any other place this needs to be changed? I only could figure out 1 place where this was hardcoded and so was obvious.
Collaborator
There was a problem hiding this comment.
I think this is the only entry point.
bantonj
dismissed
their stale review
I think passing the image type in is cleaner.
bantonj
reviewed
Apr 21, 2026
Collaborator
There was a problem hiding this comment.
Can we pass in the content type here instead of trying to figure it out from the data?
Collaborator
Author
There was a problem hiding this comment.
I will check
…trying to figure out type from header bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of forcing the contenttype to be jpeg, make it based off of image data headers.