Skip to content

Reminder mails for not billed times in past month for order responsibles (64086) - #263

Merged
Kagemaru merged 7 commits into
masterfrom
feature/64086-reminders-for-not-billed-times
Dec 18, 2025
Merged

Reminder mails for not billed times in past month for order responsibles (64086)#263
Kagemaru merged 7 commits into
masterfrom
feature/64086-reminders-for-not-billed-times

Conversation

@svenwey

@svenwey svenwey commented May 2, 2025

Copy link
Copy Markdown
Collaborator

@svenwey
svenwey requested a review from Kagemaru May 2, 2025 09:49
@svenwey svenwey self-assigned this May 2, 2025
@Kagemaru
Kagemaru force-pushed the master branch 4 times, most recently from ef26473 to 89a062c Compare November 18, 2025 23:06
@anna-dev anna-dev assigned anna-dev and unassigned svenwey Dec 9, 2025
@anna-dev
anna-dev force-pushed the feature/64086-reminders-for-not-billed-times branch from ffe2664 to f278655 Compare December 9, 2025 09:21
@anna-dev anna-dev added the ruby Pull requests that update ruby code label Dec 9, 2025
@anna-dev
anna-dev marked this pull request as ready for review December 9, 2025 15:05
@anna-dev

anna-dev commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

I changed the query in NotBilledTimesReminderJob#perform a bit so there is only one query and not 3 per active employee. I hope it's readable enough

@anna-dev
anna-dev force-pushed the feature/64086-reminders-for-not-billed-times branch from 9a9101e to c564b25 Compare December 9, 2025 15:09
@Kagemaru
Kagemaru force-pushed the feature/64086-reminders-for-not-billed-times branch from c564b25 to 87a39b9 Compare December 18, 2025 13:43
@Kagemaru
Kagemaru merged commit a71e1c5 into master Dec 18, 2025
3 checks passed
@Kagemaru
Kagemaru deleted the feature/64086-reminders-for-not-billed-times branch December 18, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ruby Pull requests that update ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants