Skip to content

Flatrates (63956) - #289

Draft
svenwey wants to merge 27 commits into
masterfrom
feature/63956-flatrate_option_for_accountingposts
Draft

Flatrates (63956)#289
svenwey wants to merge 27 commits into
masterfrom
feature/63956-flatrate_option_for_accountingposts

Conversation

@svenwey

@svenwey svenwey commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator

This adds flatrates. Flatrates can be created and planned on accounting posts and are then shown upon the creation of invoices.

@svenwey svenwey self-assigned this Jun 16, 2025
@svenwey
svenwey requested a review from Kagemaru June 16, 2025 09:17
= fields.input_field(:amount, required: true)
.col-md-1.form-action
= fields.remove_nested_fields_link(picon('delete', title: 'Pauschale entfernen'))
.row{style: "margin-bottom: 1em"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HAML-Lint] reported by reviewdog 🐶
[W] InlineStyles: Do not use inline style attributes

= fields.label :periodicity, "Periodizität *", class: 'col-md-2 control-label'
.col-md-10
- 0.upto(11) do |i|
.field.col-md-3{style: "margin-bottom: 0.5em"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HAML-Lint] reported by reviewdog 🐶
[W] InlineStyles: Do not use inline style attributes

svenwey added 21 commits June 16, 2025 11:51
…rate_invoice itself has unwanted side effects upon editing (old value used by form)
@svenwey
svenwey force-pushed the feature/63956-flatrate_option_for_accountingposts branch from d304e5c to 072da82 Compare June 16, 2025 09:52
@svenwey

svenwey commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator Author

@Kagemaru In the tests test/integration/invoice_form_test.rb I encountered a part, where the form was called with parametaers of the form invoice[period_from]=10.10.2010/invoice[period_to]=11.11.2011. The current implementation of the flatrate live refreshing in the form doesn't support this and only works if the params are set 'normally' with start_date=10.10.2010 and end_date=11.11.2011.
Is there any benefit in also supporting the former one?

- if (max_quantity == 0)
- display = 'none'

.invoice-flatrate{ style: "display: #{display};" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HAML-Lint] reported by reviewdog 🐶
[W] InlineStyles: Do not use inline style attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant