Skip to content

Townsend snow (building on #1251)#1468

Merged
kandersolar merged 29 commits into
pvlib:masterfrom
reepoi:townsend_snow_loss
Sep 12, 2022
Merged

Townsend snow (building on #1251)#1468
kandersolar merged 29 commits into
pvlib:masterfrom
reepoi:townsend_snow_loss

Conversation

@reepoi
Copy link
Copy Markdown
Contributor

@reepoi reepoi commented Jun 7, 2022

This builds off of pull request #1251 to add the changes suggested in the conversation there and wrap it up.

  • Closes Implement monthly snow loss model #1246
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement monthly snow loss model

4 participants