This repository was archived by the owner on Dec 2, 2022. It is now read-only.
Fix event type name of email_domain_changed#181
Merged
Conversation
Owner
|
Looks good, thanks! There's a lot of old code here that probably doesn't reflect the current state of the Slack API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found typo of email_domain_changed, using event types of https://api.slack.com/rtm
P.S.
file_privateis defined in Event.swift, but not listed in event type list.Still https://github.com/slackhq/slack-api-docs/blob/master/events/file_private.md exists, but
https://api.slack.com/events/file_private is not found.
It seems to be deleted, IMO.