Set default alpha to 0.05 everywhere#482
Merged
kbattocchi merged 4 commits intomasterfrom Aug 14, 2021
Merged
Conversation
heimengqi
approved these changes
Jun 11, 2021
Contributor
heimengqi
left a comment
heimengqi
left a comment
There was a problem hiding this comment.
Looks good! Have you also checked our notebooks? I feel we will have some place need to update as well (e.g. comments or code)
kbattocchi
force-pushed
the
kebatt/updateAlpha
branch
from
b78b726 to
31c8f1a
Compare
kbattocchi
force-pushed
the
kebatt/updateAlpha
branch
2 times, most recently
from
7f5dd76 to
f5821ab
Compare
kbattocchi
force-pushed
the
kebatt/updateAlpha
branch
from
f5821ab to
df6c829
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously many places were using 0.1, but 0.05 is more standard.