improve input processing for StatsModelsLinearRegression#599
Merged
kbattocchi merged 3 commits intomainfrom Apr 6, 2022
Merged
improve input processing for StatsModelsLinearRegression#599kbattocchi merged 3 commits intomainfrom
kbattocchi merged 3 commits intomainfrom
Conversation
kbattocchi
requested changes
Apr 4, 2022
Member
kbattocchi
left a comment
kbattocchi
left a comment
There was a problem hiding this comment.
Looks good, but please add a test (you can probably just take the repro in #185 and just verify that the point estimates are the same to within a small tolerance for both the sklearn LinearRegression model and ours).
|
|
||
|
|
||
| def check_input_arrays(*args, validate_len=True, force_all_finite=True): | ||
| def check_input_arrays(*args, validate_len=True, force_all_finite=True, dtype=None): |
Member
There was a problem hiding this comment.
This is a good way to address the issue.
kbattocchi
approved these changes
Apr 5, 2022
Member
kbattocchi
left a comment
kbattocchi
left a comment
There was a problem hiding this comment.
Looks good. I'll rebase on top of main once the test stability fixes are in.
kbattocchi
force-pushed
the
fverac/ImproveStatsModelsInputChecking
branch
from
401cf37 to
3d4c29a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.