initial commit for aka.ms/econml doc migration#640
Conversation
fverac
force-pushed
the
fverac/migrate_akamseconml
branch
from
83c8d66 to
7055354
Compare
vsyrgkanis
left a comment
vsyrgkanis
left a comment
There was a problem hiding this comment.
Looks good! Maybe only I would try to place the three figures in the main page of our econml project webpage, on flexbiilit ..., in the intro page of the docs.
kbattocchi
left a comment
kbattocchi
left a comment
There was a problem hiding this comment.
Looks great! Added one minor comment about image hosting.
| <div class="ms-grid " style = "text-align: left; box-sizing: border-box; display: block; margin-left: auto; margin-right: auto; max-width: 1600px; position: relative; padding-left: 0; padding-right: 0; width: 100%;"> | ||
| <div class="ms-row" style = "text-align: left; box-sizing: border-box; -webkit-box-align: stretch; align-items: stretch; display: flex; flex-wrap: wrap; margin-left: 3px; margin-right: 3px;"> | ||
| <div class="m-col-8-24 x-hidden-focus" style = "text-align: left; box-sizing: border-box; float: left; margin: 0; padding-left: 1vw; padding-right: 1vw; position: relative; width: 33.33333%;"> | ||
| <p style="text-align:center;"><img loading="lazy" class="size-full wp-image-656358 aligncenter x-hidden-focus" src="https://www.microsoft.com/en-us/research/uploads/prod/2020/05/imgFlexible.png" alt="Flexible icon" width="92" height="92"></p><p style="text-align: center"><b>Flexible</b></p><p class="x-hidden-focus">Allows for flexible model forms that do not impose strong assumptions, including models of heterogenous responses to treatment.</p><p> </p></div> |
There was a problem hiding this comment.
It might be better to copy the images locally rather than accessing them from www.microsoft.com.
| *.log | ||
| *.out | ||
| *.synctex.gz | ||
There was a problem hiding this comment.
This change is fine.
If you need to make any further changes to this PR, you might consider also changing azure-pipelines.yml to exempt .gitignore changes so that you don't have to run the full set of checks, since all of your other changes are in the doc subdirectory.
fverac
left a comment
fverac
left a comment
There was a problem hiding this comment.
sphinx-doc/sphinx#10705
Because of issues with sphinx 5.1.0
| displayName: 'Install specific version of shap' | ||
|
|
||
| - script: 'pip install sphinx sphinx_rtd_theme' | ||
| - script: 'pip install sphinx!=5.1.0 sphinx_rtd_theme' |
3 participants
Currently there is some useful documentation on the Microsoft EconML project page but it can be hard to find. Migrating the information over to the package docs should increase visibility.