CATE validation - uplift uniform confidence bands#840
Merged
kbattocchi merged 13 commits intopy-why:mainfrom Mar 19, 2024
Merged
CATE validation - uplift uniform confidence bands#840kbattocchi merged 13 commits intopy-why:mainfrom
kbattocchi merged 13 commits intopy-why:mainfrom
Conversation
kbattocchi
requested changes
Jan 24, 2024
Member
kbattocchi
left a comment
kbattocchi
left a comment
There was a problem hiding this comment.
Mostly looks great, added a few minor suggestions.
kbattocchi
approved these changes
Mar 18, 2024
…rs for uplift curves Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
…ling Signed-off-by: amarv <amarvenu@stanford.edu>
Signed-off-by: amarv <amarvenu@stanford.edu>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Co-authored-by: Keith Battocchi <kbattocchi@gmail.com> Signed-off-by: Amar Venugopal <89877778+amarvenu@users.noreply.github.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional functionality to the DRTester validation class to include uniform confidence bands (both two- and one-sided) for uplift curve plots, calculated via the multiplier bootstrap.
Modified files are:
Test cases were extended to include the modifications, maintaining 100% coverage:
Looking forward to any comments.