Fix shap_values compatibility with shap>=0.43.0 by adjusting check_additivity parameter handling for TreeExplainer#872
Merged
kbattocchi merged 1 commit intopy-why:mainfrom Apr 11, 2024
jcreinhold:main
Merged
Fix shap_values compatibility with shap>=0.43.0 by adjusting check_additivity parameter handling for TreeExplainer#872kbattocchi merged 1 commit intopy-why:mainfrom jcreinhold:main
shap_values compatibility with shap>=0.43.0 by adjusting check_additivity parameter handling for TreeExplainer#872kbattocchi merged 1 commit intopy-why:mainfrom
jcreinhold:main
Conversation
Contributor
Author
|
Adding @kbattocchi for review. |
kbattocchi
approved these changes
Apr 9, 2024
Member
kbattocchi
left a comment
kbattocchi
left a comment
There was a problem hiding this comment.
Thanks for the contribution! As I mentioned in the linked issue, if you also want to tackle passing a seed to SHAP, that would be even better, but we'll take the contribution as-is if not.
Contributor
Author
|
Great! I'm happy to add the seed functionality, but I think it's be best to add it to another PR. Ideally, I'll be able to add it within a week or so, but I might get pulled into something which will push back that timeline. |
…ditivity parameter handling for TreeExplainer Signed-off-by: Jacob Reinhold <jcreinhold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue where the
shap_valuesmethod in EconML did not correctly setcheck_additivity=Falsefor shap>=0.43.0 due to a class name change fromTreetoTreeExplainer.See #866 for details.