Optimizing NormalInferenceResults confidence interval method speed#879
Optimizing NormalInferenceResults confidence interval method speed#879kbattocchi merged 9 commits intopy-why:mainfrom
Conversation
kbattocchi
left a comment
There was a problem hiding this comment.
Thanks for the contribution! If _safe_norm_ppf already correctly handles arrays as inputs, could you also change the other places that we're doing this unnecessary zipping as part of this PR? Specifically, PopulationSummaryResults.conf_int_mean in _inference.py, and _StatsModelsWrapper.coef__interval, _StatsModelsWrapper.intercept__interval, and _StatsModelsWrapper.predict_interval in linear_model.py.
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
|
Some tests are having unstable results. |
|
@gdaiha Recent changes to the GitHub |
We've run into some unanticipated making these fixes to the build system - I'll take care of merging them into this branch once they're ready. Thanks again for your contribution! |
…y-why#879) * Fixed normal inference results confidence interval unnecessary loop Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
…y-why#879) * Fixed normal inference results confidence interval unnecessary loop Signed-off-by: gdaiha <110778471+gdaiha@users.noreply.github.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Fixing issue #878, making an optimization to NormalInferenceResults.conf_int method speed, replacing a unnecessary loop by the main usage of scipy.stats.norm.ppf function. This allows big inputs to be calculated at least 50x faster (conservative estimation).