Merged
Conversation
A breaking change to the upload-artifact GitHub Action has broken uploading coverage files (not only for us, see actions/upload-artifact#614) and has not been reverted. This change will fix that by enabling hidden files only for those uploads. Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
fverac
approved these changes
Oct 9, 2024
Collaborator
fverac
left a comment
fverac
left a comment
There was a problem hiding this comment.
Looks good.
Worth adding a comment to clarify why we need the hidden files flag? Up to you
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
carl-offerfit
pushed a commit
to carl-offerfit/EconML
that referenced
this pull request
Mar 31, 2025
A breaking change to the upload-artifact GitHub Action has broken uploading coverage files (not only for us, see actions/upload-artifact#614) and has not been reverted. This change will fix that by enabling hidden files only for those uploads. Signed-off-by: Keith Battocchi <kebatt@microsoft.com> Signed-off-by: Carl Gold <carl@offerfit.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breaking change to the upload-artifact GitHub Action has broken uploading coverage files (not only for us, see actions/upload-artifact#614) and has not been reverted. This change will fix that by enabling hidden files only for those uploads.