Skip to content

Fix tests on wx - #284

Draft
gselzer wants to merge 1 commit into
pyapp-kit:mainfrom
gselzer:test-cleanup
Draft

Fix tests on wx#284
gselzer wants to merge 1 commit into
pyapp-kit:mainfrom
gselzer:test-cleanup

Conversation

@gselzer

@gselzer gselzer commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR adds some test code to clean up Wx windows before closing out, solving some CI failures (and local warnings) noticed first in #283

Unfortunately this currently causes widget leaks in qt :(

Unfortunately this causes widget leaks in qt :(
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.96%. Comparing base (0f1407f) to head (3933405).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #284       +/-   ##
===========================================
- Coverage   85.40%   72.96%   -12.44%     
===========================================
  Files          53       53               
  Lines        7192     7192               
===========================================
- Hits         6142     5248      -894     
- Misses       1050     1944      +894     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant