Add a missing space to py35 deprecation warning#5448
Merged
reaperhulk merged 1 commit intopyca:masterfrom Sep 1, 2020
Merged
Conversation
This fixes a typo that's been introduced in pyca#5387.
webknjaz
commented
Sep 1, 2020
| warnings.warn( | ||
| "Python 3.5 support will be dropped in the next release of" | ||
| "Python 3.5 support will be dropped in the next release of " | ||
| "cryptography. Please upgrade your Python.", |
Contributor
Author
There was a problem hiding this comment.
@reaperhulk @alex have you considered including links to issues/PRs in deprecation warnings? I saw some projects doing this and I find it quite useful.
Member
There was a problem hiding this comment.
That's a good idea -- we've done it in the past once or twice but we should do it for our future support deprecations.
reaperhulk
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a typo that's been introduced in #5387:
s/release ofcryptography/release of cryptography/.