Add +/- 1 second tolerance for clock adjustments#1481
Open
crlorentzen wants to merge 5 commits intopyca:mainfrom
Open
Add +/- 1 second tolerance for clock adjustments#1481crlorentzen wants to merge 5 commits intopyca:mainfrom
crlorentzen wants to merge 5 commits intopyca:mainfrom
Conversation
mhils
reviewed
Feb 24, 2026
tests/test_crypto.py
Outdated
Member
There was a problem hiding this comment.
Would it make sense to just use 99 here, 101 below, and add a comment?
Author
There was a problem hiding this comment.
Thinking about the purpose this test, which I assume is to ensure that gmtime_adj_notBefore() works. If no one objects I'll simplify to get time once, and make the min/max be +99,+101, and the adjustment +100 as originally defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw failure in my builds And decided why not add +/-1 second tolerance for clock adjustments, probably due to NTP synchronization and python rounding.