-
Notifications
You must be signed in to change notification settings - Fork 12
Add attachment file #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The feature is awesome and it will be useful to the sponsorship team definitely. There are two items still needing your help:
|
tai271828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. We just need further information and action described in this comment #5 (comment)
|
Thx @tai271828 |
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great! Thanks for contributing! I leave 2 comments for minor issues.
|
@Lee-W Thx for your comment |
|
The code looks good to me. Thanks for the contribution! The github action looks a bit weird now. I'll reword some of your commits and handle it on my side |
Add type annotation to attachment_file.
Use if attchement instead of if attchement_file is not None
Let we can add attachment file when build mail.
Steps to Test This PR
The following steps are also performed and verified.
Send The Rendered Emails with Attachment File
Expected Result
The receivers could get the email with attachment file, and the file could open/download correctly.