Coerce union #49
Open
Coerce union #49
+644
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
force-pushed
the
friendlymatthew/union-coercion
branch
5 times, most recently
from
1fe1793 to
00ada31
Compare
adriangb
force-pushed
the
friendlymatthew/union-coercion
branch
from
00ada31 to
45de48f
Compare
github-actions
bot
added
documentation
friendlymatthew
force-pushed
the
friendlymatthew/union-coercion
branch
from
45de48f to
c160c6e
Compare
friendlymatthew
force-pushed
the
friendlymatthew/union-coercion
branch
from
c160c6e to
f108898
Compare
github-actions
bot
removed
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
For simplicity, this PR implements everything within datafusion. In a more complete design, some pieces like casting support would likely belong in arrow's cast kernel. If this PR is directionally sound and aligned with other folks, I'm happy to follow up with a properly layered implementation
Which issue does this PR close?
Uniondata type coercion apache/datafusion#18825Rationale for this change
This PR adds coercion logic for union data types. This way, you are able to compare union data types with scalar types.
Specifically making queries like the following work. (Note
attributes->'id' is aDataType::Union)When comparing a union type with a scalar type, the logic will check if the scalar type matches any Union variant
The scalar type matching is greedy, meaning if you have a Union type with variants of the same field, it will match by the smaller type id (since union variants are sorted by type id)