When hovering a heading, make the #-anchor fully opaque #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
drammock
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the heading was hovered but not the actual hash-anchor itself, the anchor would be 70% opaque. Hovering the anchor itself would bring it to 100% opacity.
However, at 70% opacity, the contrast between the #-anchor and the background did not meet accessibility contrast requirements (for normal text, WCAG AA requires 4.5:1 contrast ratio).
This PR makes it so that it's always 100% opaque, whether you hover the heading or the actual anchor itself.
This means that the anchor itself does not have a perceivable hover state, but I'm not sure it needs one. If we decide that it does need a hover state, we can add one later. At any rate, the previous 30% change in opacity to mark the hover state (hovering the heading to hovering the #-anchor) was too subtle to meet accessibility requirements.
Fixes external issue Quansight-Labs/czi-scientific-python-mgmt#96.