Fix: Chunksize when opening sharded zarr#11464
Draft
taus wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
topic-backends
topic-zarr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Zarr shards as the preferred chunk size in when opening Zarr datasets. Previously it was necessary to
know the shard size when opening to avoid error saving back to disk.
I think the term chunk is overloaded. In this case, chunk can refer to both Dask chunks and Zarr chunks, which are not necessarily the same. In the case of a shared Zarr archive, i would argue that the sensible choice of Dask chunks is the shard size. When writing to disk it could create race conditions with multiple Dask chunks in the same shard. This is also what caused the original error
Checklist