Deprecate old pandas support#1530
Merged
Merged
Conversation
jhamman
approved these changes
Aug 28, 2017
jhamman
left a comment
jhamman
left a comment
Member
There was a problem hiding this comment.
This is great. Thanks for taking this on. 0.10 is right around the corner and it will be great to have this in there.
shoyer
reviewed
Aug 28, 2017
| (:issue:`576`). | ||
| By `Stephan Hoyer <https://github.com/shoyer>`_. | ||
|
|
||
| - Deprecate supports of old numpy < 1.11 and pandas < 0.18 (:issue:`1512`). |
Member
There was a problem hiding this comment.
This should go to the top of the release notes, under a heading "Backwards incompatible changes"
Also: these versions aren't just deprecated -- they are no longer supported at all.
|
|
||
| try: | ||
| from numpy import broadcast_to, stack, nanprod, nancumsum, nancumprod | ||
| from numpy import nanprod, nancumsum, nancumprod |
Member
There was a problem hiding this comment.
We can remove nanprod, too -- it arrived in NumPy 1.10
| from numpy import broadcast_to, stack, nanprod, nancumsum, nancumprod | ||
| from numpy import nanprod, nancumsum, nancumprod | ||
| except ImportError: # pragma: no cover | ||
| # Code copied from newer versions of NumPy (v1.10 to v1.12). |
Member
|
Thanks @fujiisoup ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new APIExplicitly deprecated old pandas (< 0.18) and old numpy (< 1.11) supports.
Some backported functions in
npcompatare removed because numpy == 1.11 already has them.