More support of non-string dimension names#2373
Merged
Merged
Conversation
max-sixty
approved these changes
Aug 17, 2018
max-sixty
left a comment
max-sixty
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot @fujiisoup !
| ---------- | ||
| dim: dict, optional | ||
| Mapping from the dimension name to create the rolling iterator | ||
| along (e.g. `time`) to its moging window size. |
shoyer
reviewed
Aug 18, 2018
| results[k] = v | ||
| return results | ||
|
|
||
| def assign_coords(self, **kwargs): |
Member
There was a problem hiding this comment.
I would actually keep this one as before. It’s designed to mirror ‘assign‘, which also only accepts ‘**kwargs‘.
|
|
||
| .. [1] http://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases | ||
| """ | ||
| # TODO support non-string indexer after deprecating the old API. |
Member
I am also tempted to do this, but it’s probably safer not to. |
Member
Author
|
Thanks @max-sixty and @shoyer for your kind review. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following to #2174
In some methods, consistency of the dictionary arguments and keyword arguments are checked twice in
DatasetandVariable.Can we change the API of Variable so that it does not take kwargs-type argument for dimension names?