Skip to content

remove the compatibility code in duck_array_ops.allclose_or_equiv#4270

Merged
keewis merged 1 commit into
pydata:masterfrom
keewis:remove-dask-compat-code
Jul 26, 2020
Merged

remove the compatibility code in duck_array_ops.allclose_or_equiv#4270
keewis merged 1 commit into
pydata:masterfrom
keewis:remove-dask-compat-code

Conversation

@keewis

@keewis keewis commented Jul 25, 2020

Copy link
Copy Markdown
Collaborator

#3847 added compatibility code for dask < 2.9.1. Since we bumped to 2.9 this code can be safely removed. If we can't require dask >= 2.9.1 yet, we can wait with the merge of this PR until we can bump dask again.

  • Passes isort . && black . && mypy . && flake8

@max-sixty

Copy link
Copy Markdown
Collaborator

Thanks @keewis !

@dcherian dcherian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass!

@keewis

keewis commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator Author

let's merge, then?

@keewis keewis merged commit 9d6b174 into pydata:master Jul 26, 2020
@keewis keewis deleted the remove-dask-compat-code branch July 26, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants