Fixing non-lazy behavior of sampled+weighted#4668
Merged
Merged
Conversation
jbusecke
changed the title
mathause
approved these changes
Dec 12, 2020
mathause
left a comment
mathause
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. You added the @requires_cftime to the wrong test.
Author
|
Oops. Thanks for catching that. Should be fixed now. |
Collaborator
|
👍 do you wan't to add a what's new entry? In any case we can merge this in a few days unless someone else has a comment. |
Author
Not sure. Would you think that this is significant enough? If yes, Id be happy to do it. |
Collaborator
|
Up to you. Maybe under internal changes. |
Collaborator
|
I think #4625 is a bug, so "bug fixes" would probably be better |
dcherian
reviewed
Dec 14, 2020
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
added 2 commits
December 16, 2020 11:36
Author
|
Thanks for all the help! I made the entry to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rst