Add allow_failures flag to Dataset.curve_fit#6515
Closed
StanczakDominik wants to merge 4 commits into
Closed
Conversation
dcherian
reviewed
Apr 26, 2022
Contributor
|
Thanks @StanczakDominik can you add a test for this behaviour? The existing tests are here: xarray/xarray/tests/test_dataarray.py Line 4079 in f2d0eb4 |
Contributor
Author
|
Gah, I kept grepping for |
Collaborator
|
@StanczakDominik are you still motivated to work on these tests? |
Contributor
|
Hi! I would also like to see this implemented, so I rebased this branch and added a test in #7891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xarray.curve_fit#6317whats-new.rstFor some reason, my grepping doesn't seem to show any existing tests for
curve_fit...?