Add possibility to clean PyDicom objects#223
Merged
vsoch merged 2 commits intopydicom:masterfrom Sep 27, 2022
Merged
Conversation
vsoch
reviewed
Sep 27, 2022
Member
vsoch
left a comment
There was a problem hiding this comment.
I'll need to do a more thorough review after work - I'm open to the idea you've suggested here.
vsoch
reviewed
Sep 27, 2022
Member
vsoch
left a comment
There was a problem hiding this comment.
Nice work! Let's get tests running. If all is good, the last remaining thing to do is bump the version in deid/version.py, and then write a line in the CHANGELOG.md for it.
vsoch
reviewed
Sep 27, 2022
Contributor
Author
|
@vsoch I think we're good 👍 |
Member
|
I do too! I'm in the middle of a work day so likely I'll do one final look, merge and release this evening. Stay tuned! |
Member
|
Snuck it in :) https://pypi.org/project/deid/0.2.34/ Thank you @RobinFrcd ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The point of this PR is to add the possibility to work on PyDicom objects directly, in order to speed up the process. It indeed avoids reading the dicom file from disk twice.
Extracting the
clean_pixel_datafunction out of theDicomCleanerclass also helps when we want to process multiple images in multiple processes without having to instance multipleDicomCleanertimes (which is slow because it needs to load the recipe from disk).Checklist