fix(markers): when left hand value is non-version string, fallback to python behavior #889
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… python behavior Signed-off-by: Frost Ming <me@frostming.com>
Member
|
This correctly follows the spec but was previously rejected: #816 |
Contributor
Author
|
Good to know, that is quite unfortunate. |
Member
|
This probably requires #774 to get resolved overall before this can be merged. |
Contributor
|
The behavior of this has changed, it used to raise a InvalidVersion error, but now it returns False always, due to changes in SpecifierSet with invalid versions. As the spec still hasn't changed, would it make sense to go ahead and put this in to match the current spec vs. changing from one non-compliant behavior to another? (this idea, not this change exactly, since it now doesn't raise an InvalidVersion) |
This was referenced Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming me@frostming.com