Fix a circular import error created by #197.#225
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 75 75
Lines 6713 6713
=======================================
Hits 6322 6322
Misses 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move the import of
cli.pyto the lowest position inpytask/__init__.py.When
cliis imported, plugins will be imported before other modules likepytask.markhave been imported. But, plugins will also try to importfrom pytask import Markwhich will cause the circular import error.I am not sure whether this is a permanent fix.