Skip to content

Simplify and fix code in dag.py.#418

Merged
tobiasraabe merged 1 commit into
mainfrom
fix-dag
Sep 18, 2023
Merged

Simplify and fix code in dag.py.#418
tobiasraabe merged 1 commit into
mainfrom
fix-dag

Conversation

@tobiasraabe

@tobiasraabe tobiasraabe commented Sep 18, 2023

Copy link
Copy Markdown
Member

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.0 milestone Sep 18, 2023
@tobiasraabe tobiasraabe changed the title Simplify and fix code in dag.py Simplify and fix code in dag.py. Sep 18, 2023
@tobiasraabe tobiasraabe enabled auto-merge (squash) September 18, 2023 15:34
@codecov

codecov Bot commented Sep 18, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (60201c4) 95.38% compared to head (f9a4fb0) 95.42%.

❗ Current head f9a4fb0 differs from pull request most recent head 7ddd84d. Consider uploading reports for the commit 7ddd84d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   95.38%   95.42%   +0.03%     
==========================================
  Files          95       95              
  Lines        8422     8408      -14     
==========================================
- Hits         8033     8023      -10     
+ Misses        389      385       -4     
Flag Coverage Δ
end_to_end 82.95% <100.00%> (+0.19%) ⬆️
integration 39.40% <39.13%> (+<0.01%) ⬆️
unit 65.12% <47.82%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/shared.py 90.74% <100.00%> (-0.17%) ⬇️
tests/test_dag.py 97.84% <100.00%> (+3.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 262d6e7 into main Sep 18, 2023
@tobiasraabe tobiasraabe deleted the fix-dag branch September 18, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant