tests: make coiled an optional import#619
Merged
Merged
Conversation
Coiled has a non-free license, well no license as far as I can find. Refactored the one test which used it to skip the test if coiled is not installed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 97.80% 97.49% -0.32%
==========================================
Files 106 111 +5
Lines 8710 9261 +551
==========================================
+ Hits 8519 9029 +510
- Misses 191 232 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Hi @erooke, thanks for your proposed changes! I will take a look after the weekend. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python package
coiledhas a non-free license, it lacks any license at all from the looks of it. This PR skips testingcoiledif it is not installed making it easier to package for systems which care about only packaging free software.Changes
Splits
test_unwrap_task_functionintotest_unwrap_task_functionandtest_no_unwrap_coiledthe latter of which is skipped if coiled is not installed.Todo
I could not find the file
docs/changes.rst.