Turn _MultiCall into a function

[goodboy]

Now that #23 has landed it seems fit that we evaluate the _MultiCall type.

Afaict this class contains a single method execute() other then __init__ (and __repr__ but who uses it?) and that method was only necessary for the original recursive implementation.

I'm wondering can we simplify the whole thing into a simple function?

Reasons for:

• _MultiCall keeps no state since it's execute method is always called directly after instantiation
• _MultiCall instances are never reused
• having a function is less code, faster and arguably easier to cythonize

[RonnyPfannschmidt]

well - multicall instances are used in the sense tat we currently pick multicall vs legacy multicall

if we alter the hook calller invocation pattern then we can surely turn the actual invocation into only a function call

[nicoddemus]

I'm 👍 on the idea as well.

[goodboy]

@nicoddemus right so this will be most easily pushed through once #59 is fully in which I'd expect won't be until the next minor or even major release.

if we alter the hook calller invocation pattern

We can also just have the _LegacyMultiCall calls to __init__ and execute wrapped inside a function which is mapped in the legacy case yah? The new function approach will still need all the arguments for both calls either way.

[RonnyPfannschmidt]

@tgoodlet instantiate and initial execute can be wrapped into a function in both cases i think