Skip to content

Drop support for EOL Python 2.6 & 3.3#103

Merged
nicoddemus merged 3 commits into
pytest-dev:masterfrom
hugovk:rm-2.6
Nov 22, 2017
Merged

Drop support for EOL Python 2.6 & 3.3#103
nicoddemus merged 3 commits into
pytest-dev:masterfrom
hugovk:rm-2.6

Conversation

@hugovk

@hugovk hugovk commented Nov 20, 2017

Copy link
Copy Markdown
Member

Fixes #92.

@goodboy

goodboy commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

@hugovk looks good 👍

Do you mind tagging your commit message with Resolves #92 such that when we merge the issue will auto-close?

@hugovk

hugovk commented Nov 20, 2017

Copy link
Copy Markdown
Member Author

I certainly can do, but "Fixes #92" in the PR message should do the same:

https://help.github.com/articles/closing-issues-using-keywords/

Would you like the commit message updating?

Edit: here's a test that shows a PR message closing an issue: hugovk/test#12

@nicoddemus

Copy link
Copy Markdown
Member

@hugovk also please add a new CHANGELOG entry, I think the next version should be 0.6 because of this.

@hugovk

hugovk commented Nov 20, 2017

Copy link
Copy Markdown
Member Author

CHANGELOG updated.

Should we also drop EOL Python 3.3?

3.3 was dropped from pytest's features branch at the same time as 2.6: pytest-dev/pytest#2822.

@goodboy

goodboy commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

I certainly can do, but "Fixes #92" in the PR message should do the same:

Cool, then I don't care too much if it's git history.

3.3 was dropped from pytest's features branch at the same time as 2.6: pytest-dev/pytest#2822.

I'm 👍 on this but wait to see what @nicoddemus and @RonnyPfannschmidt say.

@nicoddemus

Copy link
Copy Markdown
Member

Should we also drop EOL Python 3.3?

Yes please. 😁

@hugovk hugovk changed the title Drop support for EOL Python 2.6 Drop support for EOL Python 2.6 & 3.3 Nov 21, 2017
@hugovk

hugovk commented Nov 21, 2017

Copy link
Copy Markdown
Member Author

Updated to drop 3.3 as well.

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugovk!

@goodboy goodboy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants