Fix #95: Resolve E741 errors#96
Merged
Merged
Conversation
The E741 (Ambiguous variable name) error has been enabled in flake8 3.5.0, which imports pycodestyle 2.1.0 [1]. Resolve the warnings. [1] PyCQA/pycodestyle#598 Signed-off-by: Stephen Finucane <stephen@that.guru>
Contributor
|
@nicoddemus @RonnyPfannschmidt looks like py3.4's been acting up in CI. |
Member
|
@tgoodlet nope, i recall this is a setuptools/pip interaction issue and i beleive 3.4 isn't eol yet |
Member
|
I ran the build again and now it passes. |
nicoddemus
approved these changes
Nov 4, 2017
nicoddemus
left a comment
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Thanks @stephenfin for the PR.
RonnyPfannschmidt
approved these changes
Nov 4, 2017
This was referenced Nov 24, 2017
This was referenced Dec 8, 2017
This was referenced Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #95: Resolve E741 errors
The E741 (Ambiguous variable name) error has been enabled in flake8 3.5.0, which imports pycodestyle 2.1.0 [1]. Resolve the warnings.
[1] PyCQA/pycodestyle#598