Skip to content

Remove unnecessary CovFailUnderWarning. Closes #675. #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ionelmc merged 1 commit into from
Apr 1, 2025
Merged

Remove unnecessary CovFailUnderWarning. Closes #675. #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/pytest_cov/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ class CovReportWarning(PytestCovWarning):
"""


class CovFailUnderWarning(PytestCovWarning):
"""
Indicates that we failed to generate a report.
"""


class CentralCovContextWarning(PytestCovWarning):
"""
Indicates that dynamic_context was set to test_function instead of using the builtin --cov-context.
Expand Down
2 changes: 0 additions & 2 deletions src/pytest_cov/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from coverage.results import should_fail_under

from . import CovDisabledWarning
from . import CovFailUnderWarning
from . import CovReportWarning
from . import compat
from . import embed
Expand Down Expand Up @@ -352,7 +351,6 @@ def pytest_runtestloop(self, session):
p=cov_precision,
)
session.config.pluginmanager.getplugin('terminalreporter').write(f'\nERROR: {message}\n', red=True, bold=True)
warnings.warn(CovFailUnderWarning(message), stacklevel=1)
# make sure we get the EXIT_TESTSFAILED exit code
compat_session.testsfailed += 1

Expand Down