Skip Django setup and manage.py scanning with "pytest --help"#238
Merged
Conversation
With `pytest --version` and `pytest --help` pytest-django should not throw an error (ImportError) in case of invalid DSM settings etc. This removes hooking into `pytest_configure` altogether, and moves the late call do `_setup_django` into the session-scoped autoload fixture instead. Fixes pytest-dev#235
blueyed
force-pushed
the
no-error-for-help-and-version
branch
from
866eacf to
61372a2
Compare
Contributor
Author
|
@pelme |
pelme
added a commit
that referenced
this pull request
Jul 25, 2015
Skip Django setup and manage.py scanning with "pytest --help". Thanks @blueyed
brianhelba
added a commit
to brianhelba/pytest-django
that referenced
this pull request
Mar 7, 2026
Previously, `pytest_load_initial_conftests` returned early when `--help` or `--version` was passed (added by pytest-dev#238), skipping `django.setup()` entirely. This caused conftest files with top-level Django model imports to fail with `AppRegistryNotReady`. Instead of returning early, continue with normal Django initialization, allowing `--help`/`--version` to return properly when everything is valid. If Django is somehow invalid (e.g. incorrect `DJANGO_SETTINGS_MODULE`), add a guard to still return gracefully if `--help`/`--version` is requested. Running real tests would still fail, but these basic informational arguments shouldn't be blocked. Fixes pytest-dev#1152
brianhelba
added a commit
to brianhelba/pytest-django
that referenced
this pull request
Mar 7, 2026
Previously, `pytest_load_initial_conftests` returned early when `--help` or `--version` was passed (added by pytest-dev#238), skipping `django.setup()` entirely. This caused conftest files with top-level Django model imports to fail with `AppRegistryNotReady`. Instead of returning early, continue with normal Django initialization, allowing `--help`/`--version` to return properly when everything is valid. If Django is somehow invalid (e.g. incorrect `DJANGO_SETTINGS_MODULE`), add a guard to still return gracefully if `--help`/`--version` is requested. Running real tests would still fail, but these basic informational arguments shouldn't be blocked. Fixes pytest-dev#1152
brianhelba
added a commit
to brianhelba/pytest-django
that referenced
this pull request
Mar 9, 2026
Previously, `pytest_load_initial_conftests` returned early when `--help` or `--version` was passed (added by pytest-dev#238), skipping `django.setup()` entirely. This caused conftest files with top-level Django model imports to fail with `AppRegistryNotReady`. Instead of returning early, continue with normal Django initialization, allowing `--help`/`--version` to return properly when everything is valid. If Django is somehow invalid (e.g. incorrect `DJANGO_SETTINGS_MODULE`), add a guard to still return gracefully if `--help`/`--version` is requested. Running real tests would still fail, but these basic informational arguments shouldn't be blocked. Fixes pytest-dev#1152
brianhelba
added a commit
to brianhelba/pytest-django
that referenced
this pull request
Jun 12, 2026
Previously, `pytest_load_initial_conftests` returned early when `--help` or `--version` was passed (added by pytest-dev#238), skipping `django.setup()` entirely. This caused conftest files with top-level Django model imports to fail with `AppRegistryNotReady`. Instead of returning early, continue with normal Django initialization, allowing `--help`/`--version` to return properly when everything is valid. If Django is somehow invalid (e.g. incorrect `DJANGO_SETTINGS_MODULE`), add a guard to still return gracefully if `--help`/`--version` is requested. Running real tests would still fail, but these basic informational arguments shouldn't be blocked. Fixes pytest-dev#1152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
pytest --versionandpytest --helppytest-django should notthrow an error (ImportError) in case of invalid DSM settings etc.
This removes hooking into
pytest_configurealtogether, and moves thelate call do
_setup_djangointo the session-scoped autoload fixture instead.Fixes #235