warnings: warning filters set by collected code during collection have no effect during test run

[bluetech]

In 2017 there was an issue #2430 complaining that module-level calls to warnings.filterwarnings are getting reset by pytest and thus have no effect. PR #2445 added a fix for this and a test testing/test_warnings.py::test_works_with_filterwarnings (still present).

In 2018 there was a change to add warning capture during collection 1a9d913. This means collection is now wrapped in a with warnings.catch_warnings and so all warnings.filterwarnings get reset after collection, regressing the issue #2430.

The tests continued to pass due to how it was written, however running pytest with -Wdefault causes it to (correctly) fail (see #13480).

Since we haven't received any complaints since it regressed, and a fix I think would be difficult, IMO we should just delete the test, basically WONTFIXing #2430.

[dfremont]

Since we haven't received any complaints since it regressed, and a fix I think would be difficult, IMO we should just delete the test, basically WONTFIXing #2430.

I would like to submit a complaint :) We set a warning filter in one of our modules to suppress warnings from a 3rd-party library (scipy), and it's quite annoying that the warnings still show up when we run our test suite. When I first looked into this a couple of years ago, I saw #2430 was closed, so I assumed there was something specific to our setup causing the problem. But I've been revisiting it recently, and I think the problem is indeed caused by the fix to #3251 that you mention above.

(I'll mention that I'm actually hoping for scipy to add an option to not emit the warnings in question in the first place; if that happens, then this issue would no longer bother us. But of course it might come up again with some other 3rd-party library.)

[RonnyPfannschmidt]

i actually have multiple places where i need a fix for this as well (i currently simply have a function that installs filter and invoke them globally and in a staggering number of pytest hooks, i just missed this issue to add my complaint

[theacodes]

I'd also like to chime in with a (friendly) "complaint", since I'd like to silence the warnings emitted due to shapely/shapely#2215, but pytest is gleefully ignoring my module-level filters. I can work around it, but I'd rather not have to. :)