triggering the release bot for 5.4

[RonnyPfannschmidt]

@pytestbot please prepare release from master

its my pleasure to trigger the first release process by bot

[pytestbot]

Sorry, the request to prepare release 5.4.0 from master failed with:

Command '['/home/runner/work/pytest/pytest/.tox/release-on-comment/bin/python', 'scripts/release.py', '5.4.0']' returned non-zero exit status 1.

See: https://github.com/pytest-dev/pytest/actions/runs/53539333.

[RonnyPfannschmidt]

failure due to ssl missmatch wrt netlify on pydanny.com

@pydanny ping?

i'll retry after the issue has been resolved

[bluetech]

Hi @RonnyPfannschmidt,

Since this release contains a lot of changes, I'd like to run some QA on the new release, like running it on our projects etc. This way if there are any "low hanging" regressions I can find them before the release. I'll do it today. Are you OK with that? (I don't think it should hold up triggering the bot, just merging the PR).

[bluetech]

BTW, it seems like my comment above, and probably this comment too, also trigger some CI action (I got an email that it failed): https://github.com/pytest-dev/pytest/runs/500150166. Probably shouldn't?

[RonnyPfannschmidt]

@bluetech i'll fix the link issue and tag the pr, that way we can see the details, the triggering seems to be a bug, i wonder if we need to fix the check wrt issue body vs issue comment body

@nicoddemus please take a look if its something quick-found or if we need to investigate

[nicoddemus]

Hmmm strange, this line here:

pytest/.github/workflows/release-on-comment.yml

Line 14 in 4f8fff9

if: (github.event.comment && contains(github.event.comment.body, '@pytestbot please')) || (github.event.issue && contains(github.event.issue.body, '@pytestbot please'))

Should ensure it would only trigger the command if the body contains the string <bot> please.

[RonnyPfannschmidt]

@nicoddemus according to https://developer.github.com/v3/activity/events/types/#issuecommentevent all comment events carry the issue body, so i think that when there is a comment, we should not look into the issue

[nicoddemus]

Yes it seems every comment on this thread is triggering it:

I will investigate this further later. We can always fallback to the manual release process, which I suggest we do for this next release if possible.

Since this release contains a lot of changes, I'd like to run some QA on the new release, like running it on our projects etc.

Will do so as well. 👍

[RonnyPfannschmidt]

test-comment 1

[RonnyPfannschmidt]

@pytestbot please release from master

[nicoddemus]

👍

[RonnyPfannschmidt]

@pytestbot please prepare release from master