Enhancement: Align pytest.warns regex mismatch error with pytest.raises (#11225)#14311
Closed
harshitlarl wants to merge 3 commits into
Closed
Enhancement: Align pytest.warns regex mismatch error with pytest.raises (#11225)#14311harshitlarl wants to merge 3 commits into
harshitlarl wants to merge 3 commits into
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Contributor
|
Hello, @harshitlarl I had already started working on this issue. Could you please close this PR? Also, for future issues, please check the existing PRs and comments on the issue beforehand to avoid duplicating work. |
Member
|
Thanks @harshitlarl, closing as duplicate of #14310. |
Author
|
Sure No Worries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11225 by aligning the error message for unmatching regex patterns in pytest.warns with the one used for pytest.raises. Handled test updates. Also added hint for re.escape() if the text strictly matches but the regex failed.