[WIP] debug/fix race with _ensure_supporting_files#4880
Closed
blueyed wants to merge 4 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## features #4880 +/- ##
=============================================
+ Coverage 71.68% 95.66% +23.98%
=============================================
Files 58 113 +55
Lines 12156 25260 +13104
Branches 2071 2504 +433
=============================================
+ Hits 8714 24165 +15451
+ Misses 2818 775 -2043
+ Partials 624 320 -304
Continue to review full report at Codecov.
|
Coverage changes by Codecov indicate that this might not be the case: https://codecov.io/gh/pytest-dev/pytest/compare/f3f6cb20933c2e1e0377d5297eb35877e8781102...83558a0ba3a737752deb7d0b1c78a0ef0ec0843c/changes This is mainly for debugging this first, since it appears to be flaky (e.g. due to xdist).
This reverts commit bb662a9.
blueyed
force-pushed
the
assert-_ensure_supporting_files
branch
from
6576671 to
8b97601
Compare
Contributor
Author
|
Looks like there is no race here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to / because of #4872.