Skip to content

Make on_setattr hooks accept generators#1592

Open
vladfedoriuk wants to merge 5 commits into
python-attrs:mainfrom
vladfedoriuk:1437-on-setattr-as-generator
Open

Make on_setattr hooks accept generators#1592
vladfedoriuk wants to merge 5 commits into
python-attrs:mainfrom
vladfedoriuk:1437-on-setattr-as-generator

Conversation

@vladfedoriuk

@vladfedoriuk vladfedoriuk commented Jul 18, 2026

Copy link
Copy Markdown

Summary

Pull Request Checklist

  • I acknowledge this project's AI policy.
  • This pull request is not from my main branch.
  • There's tests for all new and changed code.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file typing-examples/baseline.py or, if necessary, typing-examples/mypy.py.
    • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • The documentation has been updated.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signatures of @attr.s() and @attrs.define() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      The next version is the second number in the current release + 1.
      The first number represents the current year.
      So if the current version on PyPI is 26.2.0, the next version is gonna be 26.3.0.
      If the next version is the first in the new year, it'll be 27.1.0.
    • Documentation in .rst and .md files is written using semantic newlines.
  • Changes have news fragments in changelog.d.

@vladfedoriuk
vladfedoriuk marked this pull request as draft July 18, 2026 14:34
@vladfedoriuk
vladfedoriuk marked this pull request as ready for review July 18, 2026 14:47
Comment thread changelog.d/1592.change.md Outdated
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@hynek

hynek commented Jul 20, 2026

Copy link
Copy Markdown
Member

as a quick preamble: there is no such thing as 25.5.0. The current version is 26.1.0 so the next is 26.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants