Skip to content

Fix attribute collection #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hynek merged 12 commits into from
Apr 6, 2020
Merged

Fix attribute collection #635

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3f1d8bb
Checkpoint
hynek Mar 30, 2020
c5a0951
Expose to public API
hynek Mar 30, 2020
8fd7697
Add newsfragment
hynek Mar 30, 2020
bedaea3
Fix typo
hynek Mar 30, 2020
6d3f5a7
Fix test docstrings
hynek Mar 30, 2020
62dcd7c
Update changelog.d/428.change.rst
hynek Mar 30, 2020
5b3a99a
Update 635.change.rst
hynek Mar 30, 2020
1d4ff39
Update src/attr/_make.py
hynek Mar 30, 2020
1f14b34
trigger ci
hynek Mar 30, 2020
aa22303
Fix coverage
hynek Mar 30, 2020
f9f0f82
trigger ci
hynek Mar 30, 2020
ed41533
Fix sphinx markup
hynek Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update changelog.d/428.change.rst 
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
  • Loading branch information
@hynek @webknjaz
hynek and webknjaz authored Mar 30, 2020
commit 62dcd7c47464a556cde0c6532515da55027b5fa6
2 changes: 1 addition & 1 deletion changelog.d/428.change.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Added ``@attr.s(collect_by_mro=False`` argument that if set to ``True`` fixes the collection of attributes from base classes.
Added ``@attr.s(collect_by_mro=False)`` argument that if set to ``True`` fixes the collection of attributes from base classes.
Comment thread
hynek marked this conversation as resolved.

It's only necessary for certain cases of multiple-inheritance but is kept off for now for backward-compatibility reasons.
It will be turned on by default in the future.
Expand Down