Delete messages by MarcoBuster · Pull Request #84 · python-botogram/botogram

MarcoBuster · 2017-05-07T17:08:23Z

In upcoming Telegram bots API upgrade, bots will able to delete messages sent by itself and sent by users in a supergroup where the bot is admin.
I've added two new methods, message.delete() and chat.delete_message().

Example usage:

@bot.command("delete")
def delete(chat, message, args):
   if message.reply_to_message:
        message.reply_to_message.delete()
   else:
        message.reply("Reply to a message to delete it!")
        return

   message.delete()
   msg = chat.send("Message deleted, sir!")
   time.sleep(5)
   chat.delete_message(msg)  # Or msg.delete()

emilyalbini · 2017-05-07T17:18:09Z

botogram/objects/mixins.py

        return self._api.call("sendContact", args, expect=_objects().Message)

+    @_require_api
+    def delete_message(self, message):


You forgot to add the docstring.

emilyalbini · 2017-05-07T17:20:02Z

botogram/objects/mixins.py

+            message = message.message_id
+
+        return self._api.call("deleteMessage", {
+            "chat_id": self.id, "message_id": message


Can you put all of these on their own line, with a traling comma in all of them?

{ "chat_id": self.id, "message_id": message, }

emilyalbini · 2017-05-07T17:21:17Z

botogram/objects/mixins.py

+    def delete(self):
+        """Delete the message"""
+        return self._api.call("deleteMessage", {"chat_id": self.chat.id,
+                                                "message_id": self.message_id})


Use the same style for the parameters as the other method.

emilyalbini · 2017-05-07T17:21:47Z

docs/api/telegram.rst

+
+      Delete the selected message.
+      A message can be deleted only if is sent by the bot or sent in a supergroup by an user where the bot is admin.
+


You forgot to add the versionadded (0.4) and the documentation for the parameter.

emilyalbini · 2017-05-07T17:22:03Z

docs/api/telegram.rst

+
+      Delete the message self.
+      A message can be deleted only if is sent by the bot or sent in a supergroup by an user where the bot is admin.
+


You forgot to add the versionadded (0.4)

MarcoBuster · 2017-05-07T17:32:27Z

@pietroalbini Done, it's all ok, right?

emilyalbini

LGTM

emilyalbini

LGTM

MarcoBuster · 2017-05-21T16:47:35Z

@pietroalbini Maybe we're ready to merge?

emilyalbini · 2017-05-21T17:25:25Z

Can you add in the docs that in supergroups it's possibile to delete some service messages?

emilyalbini · 2017-06-14T21:08:01Z

docs/api/telegram.rst


+   .. py:method:: delete()
+
+      Delete the message self.


What? "Delete this message. The message can be deleted only if... It can also be deleted if it's one of the supported service messages."

emilyalbini · 2017-06-14T21:08:25Z

docs/api/telegram.rst


+   .. py:method:: delete_message(message)
+
+      Delete the selected message.


"Delete the message with the provided ID"

...or botogram.Message object

emilyalbini

LGTM

MarcoBuster force-pushed the delete-messages branch from c7cf540 to a56b456 Compare May 7, 2017 17:10

emilyalbini suggested changes May 7, 2017

View reviewed changes

emilyalbini added this to the botogram 0.4 milestone May 7, 2017

emilyalbini previously approved these changes May 7, 2017

View reviewed changes

MarcoBuster dismissed emilyalbini’s stale review via c5c1262 May 7, 2017 19:17

MarcoBuster force-pushed the delete-messages branch from 663ce2e to c5c1262 Compare May 7, 2017 19:17

emilyalbini previously approved these changes May 7, 2017

View reviewed changes

MarcoBuster dismissed emilyalbini’s stale review via a6f4efe June 14, 2017 17:11

MarcoBuster force-pushed the delete-messages branch from c5c1262 to a6f4efe Compare June 14, 2017 17:11

emilyalbini suggested changes Jun 14, 2017

View reviewed changes

Add message.delete() and chat.delete_message()

2ce9f50

MarcoBuster force-pushed the delete-messages branch from a6f4efe to 2ce9f50 Compare June 15, 2017 09:54

emilyalbini approved these changes Jun 15, 2017

View reviewed changes

emilyalbini merged commit 2ce9f50 into python-botogram:master Jun 15, 2017


		Delete the selected message.
		A message can be deleted only if is sent by the bot or sent in a supergroup by an user where the bot is admin.


		Delete the message self.
		A message can be deleted only if is sent by the bot or sent in a supergroup by an user where the bot is admin.


		.. py:method:: delete_message(message)

		Delete the selected message.

Conversation

MarcoBuster commented May 7, 2017

Uh oh!

emilyalbini May 7, 2017

Choose a reason for hiding this comment

Uh oh!

emilyalbini May 7, 2017

Choose a reason for hiding this comment

Uh oh!

emilyalbini May 7, 2017

Choose a reason for hiding this comment

Uh oh!

emilyalbini May 7, 2017

Choose a reason for hiding this comment

Uh oh!

emilyalbini May 7, 2017

Choose a reason for hiding this comment

Uh oh!

MarcoBuster commented May 7, 2017

Uh oh!

emilyalbini left a comment

Choose a reason for hiding this comment

Uh oh!

emilyalbini left a comment

Choose a reason for hiding this comment

Uh oh!

MarcoBuster commented May 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilyalbini commented May 21, 2017

Uh oh!

emilyalbini Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

emilyalbini Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

MarcoBuster Jun 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilyalbini left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

MarcoBuster commented May 21, 2017 •

edited

Loading

MarcoBuster Jun 15, 2017 •

edited

Loading