Fix python2.6 support#232
Merged
nir0s merged 8 commits intoFeb 3, 2019
Merged
Conversation
abadger
force-pushed
the
fix-python2.6-support
branch
3 times, most recently
from
7c657d2 to
1f7a54b
Compare
abadger
pushed a commit
to ansible/ansible
that referenced
this pull request
Dec 17, 2018
* Port bundled distro to use optparse instead of argparse (py2.6) * Use an absolute import to satisfy the current import testing harness * Port from subprocess.check_output to subprocess.Popen.communicate() (py2.6) * Add license location The changes have been proposed upstream here: python-distro/distro#232 Upstream is contemplating a branch where everyone wanting python-2.6 support can collaborate without it becoming part of the regularly supported releases.
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
* Port bundled distro to use optparse instead of argparse (py2.6) * Use an absolute import to satisfy the current import testing harness * Port from subprocess.check_output to subprocess.Popen.communicate() (py2.6) * Add license location The changes have been proposed upstream here: python-distro/distro#232 Upstream is contemplating a branch where everyone wanting python-2.6 support can collaborate without it becoming part of the regularly supported releases.
Collaborator
|
@abadger, LGTM. Can you please fix conflicts? |
* Port the 2.7 version of check_output that we're bundling for 2.6 * Only use our check_output when running on a Python which does not have subprocess.check_output * Pull check_output code to the toplevel because it isn't conceptually part of LinuxDistribution
abadger
force-pushed
the
fix-python2.6-support
branch
from
a308ecd to
103e388
Compare
Contributor
Author
|
Rebased and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #231 to get the nir0s/distro python2.6-support branch working on Python-2.6.