Skip to content

Use sys.executable in flake8 plugin to make tests pass on systems that don't provide a python link#111

Merged
ccordoba12 merged 2 commits into
python-lsp:developfrom
0-wiz-0:develop
Nov 13, 2021
Merged

Use sys.executable in flake8 plugin to make tests pass on systems that don't provide a python link#111
ccordoba12 merged 2 commits into
python-lsp:developfrom
0-wiz-0:develop

Conversation

@0-wiz-0

@0-wiz-0 0-wiz-0 commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

Part of #109.

@ccordoba12 ccordoba12 changed the title Use sys.executable to make tests pass on systems that don't provide "… Use sys.executable to make tests pass on systems that don't provide a python link Nov 5, 2021

@ccordoba12 ccordoba12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0-wiz-0, thanks for your help with this! Please fix the error reported by Pylint so I can merge this one.

@0-wiz-0

0-wiz-0 commented Nov 13, 2021

Copy link
Copy Markdown
Contributor Author

I've just pushed a change that fixes the pylint warning when I run pylint locally. Thanks for the review!

@ccordoba12 ccordoba12 added this to the v1.3.0 milestone Nov 13, 2021

@ccordoba12 ccordoba12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @0-wiz-0!

@ccordoba12 ccordoba12 changed the title Use sys.executable to make tests pass on systems that don't provide a python link Use sys.executable in flake8 plugin to make tests pass on systems that don't provide a python link Nov 13, 2021
@ccordoba12 ccordoba12 merged commit 1b649df into python-lsp:develop Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants