Add mccabe setting to flake8#63
Merged
Merged
Conversation
This config key belongs to the flag used in flake8 to set MCcabe's threshold for complexity.
Contributor
|
@ccordoba12 any chance this could be merged? |
Member
|
Sorry, I missed this one completely. @baco, do you have time to fix the merge conflict? Or do you prefer for me to do it? |
Contributor
Author
|
@ccordoba12 I'll look into it later today :-) |
Contributor
Author
|
@ccordoba12 There, I've solved the conflict with the branch |
ccordoba12
approved these changes
Nov 9, 2022
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution @baco!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flake8 can also wrap mccabe complexity linter. In order to support those flags, added the corresponding configuration key to flake8 plugin in Python LSP server.
If such option is not available mccabe linter is never invoked, because default value for mccabe threshold in flake8 is
-1which means “deactivated”