ICO: Only save relevant sizes#2267
Merged
Merged
Conversation
hugovk
added a commit
that referenced
this pull request
Sep 5, 2017
Code was fixed in #2267 but not the docs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2266.
Includes PR #2265 that fixes #2264.
See the antepenultimate commit for a failing case for this, and the last two commits to fix it.
The return from
filterwas being ignored.For
width, height = 64, 64it returns:[(16, 16), (24, 24), (32, 32), (48, 48), (64, 64)]For
width, height = 256, 256it returns:[(16, 16), (24, 24), (32, 32), (48, 48), (64, 64), (128, 128), (256, 256)]Running the test in #2266 gives: