Return None if display profile not found in ImageCms.get_display_profile #4372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building and running Pillow tests in a Windows Server Docker instance fails for two tests
test_imagecms.test_display_profileandtest_imagegrab.test_grabbecause it is run headless.While I think the
test_grabfailure is reasonable, the other test fails with a TypeError raised fromImageCms.get_display_profile, which is confusing at best. This is caused byImageCms.core.get_display_profile_win32returning None, which is obviously not accepted by theImageCmsProfileconstructor. This PR proposes returning None instead (in accordance with the functions docs).